search

RuntimeTools / SwiftMetrics

Swift Application Metrics instruments the Swift runtime for performance monitoring, providing the monitoring data programatically via an API or visually with an Eclipse Client.
https://developer.ibm.com/swift/monitoring-diagnostics/application-metrics-for-swift/
Other
156 stars 50 forks source link

Compilation warnings #69

Closed rolivieri closed 7 years ago

rolivieri commented 7 years ago

The following warnings are thrown by the swift compiler when an application includes SwiftMetrics as a dependency (it looks like these warnings are coming from the following internal dependency for metrics: https://github.com/RuntimeTools/omr-agentcore):

Compile paho src/MQTTPersistence.c
/Users/olivieri/git/swift-enterprise-demo/Packages/omr-agentcore-3.1.1/src/paho/src/Thread.c:233:8: warning: 'sem_init' is deprecated [-Wdeprecated-declarations]
                rc = sem_init(sem, 0, 0);
                     ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/sys/semaphore.h:55:5: note: 'sem_init' has been explicitly marked deprecated here
int sem_init(sem_t *, int, unsigned int) __deprecated;
    ^
/Users/olivieri/git/swift-enterprise-demo/Packages/omr-agentcore-3.1.1/src/paho/src/Thread.c:300:2: warning: 'sem_getvalue' is deprecated [-Wdeprecated-declarations]
        sem_getvalue(sem, &semval);
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/sys/semaphore.h:54:5: note: 'sem_getvalue' has been explicitly marked deprecated here
int sem_getvalue(sem_t * __restrict, int * __restrict) __deprecated;
    ^
/Users/olivieri/git/swift-enterprise-demo/Packages/omr-agentcore-3.1.1/src/paho/src/Thread.c:354:8: warning: 'sem_destroy' is deprecated [-Wdeprecated-declarations]
                rc = sem_destroy(sem);
                     ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/include/sys/semaphore.h:53:5: note: 'sem_destroy' has been explicitly marked deprecated here
int sem_destroy(sem_t *) __deprecated;
    ^
3 warnings generated.

And 

Compile agentcore ibmras/common/PropertiesFile.cpp
/Users/olivieri/git/swift-enterprise-demo/Packages/omr-agentcore-3.1.1/src/agentcore/ibmras/common/port/ThreadData.cpp:34:11: warning: implicit conversion of NULL constant to 'uintptr_t' (aka 'unsigned long') [-Wnull-conversion]
        handle = NULL;
               ~ ^~~~
                 0
/Users/olivieri/git/swift-enterprise-demo/Packages/omr-agentcore-3.1.1/src/agentcore/ibmras/common/port/ThreadData.cpp:43:11: warning: implicit conversion of NULL constant to 'uintptr_t' (aka 'unsigned long') [-Wnull-conversion]
        handle = NULL;
               ~ ^~~~
                 0
2 warnings generated.
stalleyj commented 7 years ago

The ThreadData warnings will be removed by https://github.com/RuntimeTools/omr-agentcore/pull/32

stalleyj commented 7 years ago

Also fixed the paho warnings.

stalleyj commented 7 years ago

We've stamped the core now to 3.2 so SwiftMetrics will pick up those changes and we should be clear of compile warnings