search

RuntimeTools / appmetrics-dash

A data visualizer that uses " Node Application Metrics" (appmetrics) to monitor and display Node.js application data as a html web application.
Other
452 stars 55 forks source link

Absolute, non-configurable path to socket.io #163

Closed s-h-a-d-o-w closed 5 years ago

s-h-a-d-o-w commented 5 years ago

Before this change, the relative path assumed that index.html is served from /appmetrics-dash. Which causes an error if the user specifies a custom path in the dash options. Since socket.io is always served from /appmetrics-dash, we might as well refer to it in a fixed way here.

Fixes #160

codecov-io commented 5 years ago

Codecov Report

Merging #163 into master will increase coverage by 0.48%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   63.94%   64.42%   +0.48%     
==========================================
  Files           4        4              
  Lines         416      416              
==========================================
+ Hits          266      268       +2     
+ Misses        150      148       -2
Impacted Files Coverage Δ
lib/appmetrics-dash.js 60.92% <0%> (+0.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f5cf3f3...2a847a5. Read the comment docs.