search

RuntimeTools / appmetrics-dash

A data visualizer that uses " Node Application Metrics" (appmetrics) to monitor and display Node.js application data as a html web application.
Other
456 stars 55 forks source link

Fix #140 by using URL prefix passed in as part of options #165

Closed achingbrain closed 6 years ago

achingbrain commented 6 years ago

The current release accepts a url option for deploying the dashboard on a custom path, but then uses hard-coded paths for loading the socket.io library and then connecting to the websocket.

This PR makes it work with the default path (/appmetrics-dash) and also with a custom path specified by the user.

tobespc commented 6 years ago

@achingbrain Thanks for raising this but before we can accept, please can you confirm you have read https://github.com/RuntimeTools/appmetrics-dash/blob/master/CONTRIBUTING.md and added your name to the authors file

codecov-io commented 6 years ago

Codecov Report

Merging #165 into master will decrease coverage by 1.68%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   65.62%   63.94%   -1.69%     
==========================================
  Files           4        4              
  Lines         416      416              
==========================================
- Hits          273      266       -7     
- Misses        143      150       +7
Impacted Files Coverage Δ
lib/appmetrics-dash.js 60.26% <100%> (-2.65%) :arrow_down:
lib/classes/collections.js 66% <0%> (+2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfd0ba5...3c49860. Read the comment docs.

achingbrain commented 6 years ago

Done!

achingbrain commented 6 years ago

@tobespc thanks for merging this - when do you think it'll be released?