search

RuntimeTools / appmetrics

Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.
https://developer.ibm.com/open/node-application-metrics/
Apache License 2.0
974 stars 125 forks source link

There is no description of support of node.js 10 #571

Closed takahashi-jiec closed 5 years ago

takahashi-jiec commented 5 years ago

I think that the description of Node.js 10 of README.md is necessary.

Supported platforms

The Node Application Metrics agent supports the following runtime environments where a Node.js runtime is available:

--------------------↓--------------------

Supported platforms

The Node Application Metrics agent supports the following runtime environments where a Node.js runtime is available:

yuecchen commented 5 years ago

will you support win10?

I got an error while compiling on win10:

MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0".
gyp ERR! build error
gyp ERR! stack Error: `C:\Windows\Microsoft.NET\Framework\v4.0.30319\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\YUECHEN\AppData\Roaming\npm\node_modules\npm\node_modules\node-gyp\lib\build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Windows_NT 10.0.17134
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\YUECHEN\\AppData\\Roaming\\npm\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\projects\nodejs-internal\opentracing\Nodejs-Data-Collector\ibmapm\node_modules\appmetrics
gyp ERR! node -v v10.15.3
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! appmetrics@4.0.1 install: `node extract_all_binaries.js || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the appmetrics@4.0.1 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\YUECHEN\AppData\Roaming\npm-cache\_logs\2019-04-29T01_39_39_169Z-debug.log
takahashi-jiec commented 5 years ago

Try the following:

node extract_all_binaries.js || node-gyp rebuild
rwalle61 commented 5 years ago

@takahashi-jiec we are checking which versions we support right now and will update the doc when we know. For example, I'm currently nearly finished fixing Appmetrics for Node 12 on mac (see https://github.com/RuntimeTools/appmetrics/issues/572).

takahashi-jiec commented 5 years ago

@rwalle61 Thank you

mattcolegate commented 5 years ago

@yuecchen, I've confirmed that Appmetrics installs and npm tests sucessfully using Node 10 on Windows 10. I suspect the problem you're having is with your build environment, as Appmetrics on Node 10 now has to build native binaries rather than having them shipped with the package. I used https://github.com/nodejs/node-gyp#option-1 to obtain a working environment. It looks like you already have some Microsoft build tools installed, this issue thread might help: https://github.com/chjj/pty.js/issues/60 When we update the readme with statements of supported levels, we will include a link to the node-gyp readme for Windows users to make it obvious they need build tools for native binaries.

rwalle61 commented 5 years ago

Closing as the README https://github.com/RuntimeTools/appmetrics/blob/master/README.md now describes support of Node 10