Cannot install appmetrics with Node.js v12 on MacOS

RuntimeTools / appmetrics

Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.

https://developer.ibm.com/open/node-application-metrics/

Apache License 2.0

974 stars 125 forks source link

Cannot install appmetrics with Node.js v12 on MacOS #572

Closed yuecchen closed 5 years ago

yuecchen commented 5 years ago

With Node.js v12, run npm install appmetrics, we got some error while compile:

Release/obj.target/appmetrics/geni/appmetrics.cpp:665:52: error: no matching
      member function for call to 'ToObject'
            Local<Value> gpfilename = grandparent->ToObject()->Get(Nan::...
                                      ~~~~~~~~~~~~~^~~~~~~~
/Users/yuecchen/.node-gyp/12.0.0/include/node/v8.h:2532:44: note: candidate
      function not viable: requires single argument 'context', but no arguments
      were provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(

and

../src/plugins/node/prof/compat-inl.h:302:19: error: no member named
      'GetCpuProfiler' in 'v8::Isolate'
  return isolate->GetCpuProfiler()->StartProfiling(title, record_samples);
         ~~~~~~~  ^
../src/plugins/node/prof/compat-inl.h:312:19: error: no member named
      'GetCpuProfiler' in 'v8::Isolate'
  return isolate->GetCpuProfiler()->StopProfiling(title);
         ~~~~~~~  ^

here is the install log: 2018-11-28T14_57_12_372Z-debug.log

rwalle61 commented 5 years ago

@yuecchen thanks for opening the issue, I'm working on it now.

Progress:

[x] recreate
[x] get Node 12 compiling
[x] get tests passing for Node 12
[x] check Node 10 still compiles
[x] check Node 10 still passes tests
[x] check Node 8 still compiles
[x] check Node 8 still passes tests
[x] raise PR
[x] implement review suggestions
[x] get Travis working
[x] merge
[x] raise issues for future work
[x] legals
[x] release new major version (as this removes support for Node 6)

Update: https://github.com/RuntimeTools/appmetrics/pull/576 is passing Travis on Mac and Linux, for Node 8, 10, and 12

rwalle61 commented 5 years ago

Update: https://github.com/RuntimeTools/appmetrics/pull/576 has been merged!

rwalle61 commented 5 years ago

@yuecchen can you pull Appmetrics 5.0.0 and see if you can install on Node 12?

rwalle61 commented 5 years ago

As you closed https://github.com/RuntimeTools/appmetrics/issues/573, I assume this is safe to close too

nithil commented 4 years ago

This is not working on v12.13, also tried on v12.6

mattcolegate commented 4 years ago

@n1th1l Our Travis test for Appmetrics 5.1.1 on Node 12.13 on MacOS passed cleanly: https://travis-ci.org/RuntimeTools/appmetrics/jobs/606748803?utm_medium=notification&utm_source=github_status Can you provide some more detail on the problems you are seeing please?

tmkasun commented 3 years ago

I tried to install appmetrics on node v12.18.3 in mac catalina, It's not working. getting bunch of

error: no matching
      member function for call to 'ToObject'

errors

mattcolegate commented 3 years ago

@tmkasun Our latest Travis test for Appmetrics 5.1.1 on Node 12.18.4 failed in the test stage but did pass installation: https://travis-ci.org/github/RuntimeTools/appmetrics/jobs/733041231

Can you provide the entire log output for the installation attempt please?