Cannot install appmetrics with Node.js v12 on Redhat Linux

[yuecchen]

With Node.js v12, run npm install appmetrics, we got some error while compile:

/root/.node-gyp/12.0.0/include/node/v8.h:5947:46: note:   candidate expects 1 argument, 0 provided
Release/obj.target/appmetrics/geni/appmetrics.cpp:724:148: error: no matching function for call to ‘v8::FunctionTemplate::GetFunction()’
     exports->Set(Nan::New<String>(asciiString("sendControlCommand")).ToLocalChecked(), Nan::New<FunctionTemplate>(sendControlCommand)->GetFunction());
                                                                                                                                                    ^
Release/obj.target/appmetrics/geni/appmetrics.cpp:724:148: note: candidate is:
In file included from /root/.node-gyp/12.0.0/include/node/node.h:63:0,
                 from Release/obj.target/appmetrics/geni/appmetrics.cpp:21:
/root/.node-gyp/12.0.0/include/node/v8.h:5947:46: note: v8::MaybeLocal<v8::Function> v8::FunctionTemplate::GetFunction(v8::Local<v8::Context>)
   V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
                                              ^
/root/.node-gyp/12.0.0/include/node/v8.h:5947:46: note:   candidate expects 1 argument, 0 provided
Release/obj.target/appmetrics/geni/appmetrics.cpp:726:156: error: no matching function for call to ‘v8::FunctionTemplate::GetFunction()’
     exports->Set(Nan::New<String>(asciiString("setHeadlessZipFunction")).ToLocalChecked(), Nan::New<FunctionTemplate>(setHeadlessZipFunction)->GetFunction());
                                                                                                                                                            ^
Release/obj.target/appmetrics/geni/appmetrics.cpp:726:156: note: candidate is:
In file included from /root/.node-gyp/12.0.0/include/node/node.h:63:0,
                 from Release/obj.target/appmetrics/geni/appmetrics.cpp:21:
/root/.node-gyp/12.0.0/include/node/v8.h:5947:46: note: v8::MaybeLocal<v8::Function> v8::FunctionTemplate::GetFunction(v8::Local<v8::Context>)
   V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
                                              ^

Redhat version:

[root@joycevm1 buildAPMAgent]# cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.6 (Maipo)

Linux core:

[root@joycevm1 buildAPMAgent]# uname -a
Linux xxx.xxx.xxx.xxx 3.10.0-862.14.4.el7.x86_64 #1 SMP Fri Sep 21 09:07:21 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

[rwalle61]

@yuecchen I am fixing Node 12 for mac (re your issue https://github.com/RuntimeTools/appmetrics/issues/572), then we will look at these Linux-specific errors

[yuecchen]

Could we possible accelerate the linux issue fixing? or put it priority higher than issue 572? We plan to deliver this feature by the end of May.

[yuecchen]

verified