search

RuntimeTools / appmetrics

Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.
https://developer.ibm.com/open/node-application-metrics/
Apache License 2.0
977 stars 126 forks source link

Disable watchdog when sigev_notify_thread_id is unavailable (fixes #582) #597

Closed rhowe-gds closed 5 years ago

rhowe-gds commented 5 years ago

This is the case e.g. on Alpine Linux, which uses musl libc.

Correct the logic in the original commit (48682de6d6187c15f9bb6b32bfa2f4c26733153f)

Note that I have only tested this compiles on Alpine 3.10 - it probably wants testing on non-Alpine systems

rhowe-gds commented 5 years ago

This is a fix for the change in https://github.com/RuntimeTools/appmetrics/pull/587 which had the logic the wrong way around (but only in the #if - it was correct in the comments for the #else and #endif)

rhowe-gds commented 5 years ago

@rwalle61 Does this look good to you?

tobespc commented 5 years ago

Before I can merge this, please confirm you have read https://github.com/RuntimeTools/appmetrics/blob/master/CONTRIBUTING.md and add your name to the authors file. Thanks

rhowe-gds commented 5 years ago

Before I can merge this, please confirm you have read https://github.com/RuntimeTools/appmetrics/blob/master/CONTRIBUTING.md and add your name to the authors file. Thanks

Done