resolve compile errors from v8 API incompatibilities with node-v12

RuntimeTools / appmetrics

Node Application Metrics provides a foundational infrastructure for collecting resource and performance monitoring data for Node.js-based applications.

https://developer.ibm.com/open/node-application-metrics/

Apache License 2.0

970 stars 125 forks source link

resolve compile errors from v8 API incompatibilities with node-v12 #628

Closed gabylb closed 4 years ago

gabylb commented 4 years ago

Checklist

[x] npm install && npm test passes
[x] commit message follows commit guidelines

Description of change

src/plugins/node/memory/nodezmemoryplugin.cpp fails to compile due to v8 incompatibility with node-v12; this fix enables it to compile under node-v8 and node-v12 (versions that I tested).

gabylb commented 4 years ago

The build job that failed is likely a build environment issue. @mattcolegate can you please confirm.

mattcolegate commented 4 years ago

Confirmed - re-ran failing travis builds and they passed