search

Rup0rt / pcapfix

repair corrupted pcap files
http://f00l.de/pcapfix/
GNU General Public License v3.0
205 stars 34 forks source link

Makefile, line 1: Badly formed macro assignment #22

Open 8uachaille opened 3 years ago

8uachaille commented 3 years ago

me@myhost# git clone https://github.com/Rup0rt/pcapfix.git Cloning into 'pcapfix'... remote: Enumerating objects: 665, done. remote: Total 665 (delta 0), reused 0 (delta 0), pack-reused 665 Receiving objects: 100% (665/665), 272.77 KiB | 0 bytes/s, done. Resolving deltas: 100% (438/438), done. Checking connectivity... done.

me@myhost# make make: Fatal error in reader: Makefile, line 1: Badly formed macro assignment

me@myhost:/mydir# uname -a SunOS fireworks 5.11 11.3 sun4v sparc SUNW,SPARC-Enterprise-T5120

Rup0rt commented 3 years ago

I really have no clue how SunOS' make differs. Can you check the devel branch whether this error still exists?

8uachaille commented 3 years ago

HI,

I got it to work on CentOS in the end and it repaired my file as I had hoped.

Thanks very much for your work on this and for following-up.

Rup0rt commented 3 years ago

Hi,

glad to hear. Nevertheless it's bad that it does not compile on SunOS.

Maybe somebody else using SunOS can check it out?

mdeweerd commented 3 years ago

I worked a very long time ago in SunOS. The Makefile in this project is for GNU Make, so one should use GNU make on SunOS as well.

It is possible to call GNU's make "gmake" through a link or possibly at compilation/build time. Then use "gmake".

Or, set the environment variable MAKE to the GNU Make executeable and use an alias or point make to GNU's make.

Rup0rt commented 3 years ago

Thank you for this information. So if I understand this right, it is not a bug? Adding a hint in the INSTALL file should be enough thou?

mdeweerd commented 3 years ago

IMHO it is not a bug - there are different flavors of Makefile's. You can indicate that GNU Make and GNU-C/C++ is required. make -v should show something similar to 'GNU Make 4.3' in its output.

Rup0rt commented 3 years ago

Great! I am going to add a note to INSTALL file. Thank you, mdeweerd.

8uachaille commented 3 years ago

Thank you both for looking into this problem

The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.