curiousjp
commented
8 months ago Well - I feel silly now. After build a local copy and doing some tests, it seems the issue is not the non-writing of OtherParameters but that the aestheticScore variable doesn't appear to be written to fileParameters.AestheticScore. Adding a line to do that at 1001 and 149 seems to have fixed the problem.
RupertAvery
Describe the bug PNG files from A1111 that embed a separate aesthetic_score tag in a PNG-tEXt block do not have this information read into their FileParameters structure, due to the OtherParameters field already being set elsewhere.
Version: v1.4. The extension embedding the tag is stable-diffusion-webui-aesthetic-image-scorer, version 1c3ab7a1.
To Reproduce Generate an image and have it loaded into Diffusion Toolkit. Set a search that uniquely identifies this image. Add a filter for aesthetic_score > 0. The image is filtered out.
Expected behavior The image should remain, as it has an aesthetic score of 6.2.
Source Image
Note that the parameters: tag starts at offset 33, and the aesthetic_score resides in a separate tag at offset 333.
Additional context My hypothesis is that the problem is in the ReadFromFile function in Metadata.cs.
During execution, we encounter the "parameters:" tag and ReadA111Parameters is called. The tag is split and iterated over. During this, the function moves to state 2 as the tag includes the line, "Steps: 20, Sampler: DPM++ 2M Karras, CFG scale: 7, Seed: 43846133, Size: 512x512, Model hash: 5dd07a46d7, Model: richyrichmix_V2Fp16, VAE hash: df3c506e51, VAE: pastel-waifu-diffusion.vae.pt, Clip skip: 2, Token merging ratio: 0.5, Version: v1.7.0". Note that this tag fragment does not include the aesthetic score.
On line 866, this tag fragment is stored in fileParameters.OtherParameters, and eventually this fileParameters structure is returned to the outer function. Subsequently, the "aesthetic_score:" tEXt block may be encountered at line 103 and the value stored in aestheticScore, but this is not propagated into the fileParameters structure at line 149 because fileParameters.OtherParameters is no longer null and therefore the ??= assignment does not take place.
Suggestion If I have understood correctly, the block of code at 148-149 should test in the alternative if OtherParameters is set - if not, the current behaviour is correct, but otherwise the aesthetic score should be appended if it is not already present from an earlier read operation.