search

Rurik / Noriben

Noriben - Portable, Simple, Malware Analysis Sandbox
Other
1.1k stars 223 forks source link

Empty text and timeline file generated by Noriben #37

Open VikramKharvi opened 4 years ago

VikramKharvi commented 4 years ago

The current release doesn't print anything in txt and timeline file. Git committed on Mar 25, 2019 has no such errors.

Rurik commented 4 years ago

Thank you. I'm troubleshooting this with another issue now. However, I've been unable to reproduce.

What version of Windows are you attempting this on? Is there a .csv file that is produced with data?

Rurik commented 4 years ago

If possible, could you run it with the "-d" option and send the resulting ".log"? Either here or, if it has sensitive info, to brian [@] thebaskins [.] com

VikramKharvi commented 4 years ago

I ran Noriben.py in Windows 8 and Windows 10 latest build. There is .csv file being generated from procmon but I could see no data going from csv to parse in the parse_csv() function. I did try with different methods but would take more time in order to recreate it again.

stryker2k2 commented 4 years ago

Howdy. I am having the same issue. Likewise, it seems that Issue #4 from about 5 years ago is very similar to this issue.

The truth is that... this is the BEST Malware Analysis Tool I've ever used and I can't imagine my life without it. Please fix and keep up the good work... FOREVER.

stryker2k2 commented 4 years ago

I've 'fixed' mine.

I moved 'ProcmonConfiguration.pmc' from '/Noriben/filters' to '/Noriben' then re-ran.

All seems to be working fine now.

VikramKharvi commented 4 years ago

It worked for me too. Kindly update same in the main repo and close the issue

Rurik commented 4 years ago

This is an embarrassing mistake. Thank you to everyone. I did move that file to cleanup the repo and I did not think through when the repo gets cloned and executed. And something that would've been incredibly hard for me to determine without your help.

I will commit the change this weekend, as I have to keep a strict distance from this code and my day job.

VikramKharvi commented 4 years ago

The CSV report generated by Noriben.py seems to be missing lots of information.

Rurik commented 4 years ago

In more testing, I still cannot reproduce. I created a new VM snapshot without Noriben, copied the repo directly as-is, with the filters folder in place. Windows 10 and Windows 7, Python 3.6 and 3.7.

I suspect there's an environment issue that I did not foresee and cannot determine.

I can push a change to move the file, and to add in the additional debugging code I've added, but I'm hesitant to close this. I suspect it may be a similar issue to #4 where I closed it but am not 100% sure I caught the issue.

It's extreme, but if someone who is exhibiting this problem would not mind a video conference where I can control their VM to test, please let me know by email.

astrelsky commented 2 years ago

@Rurik I've been facing this problem for a while now and finally had a moment to debug it. Changing the following to if len(field) != 8: appears to have fixed it.

https://github.com/Rurik/Noriben/blob/master/Noriben.py#L1014

Rurik commented 2 years ago

Thank you @astrelsky. That does change a significant check and could break backward compatibility. I will review and test here. That could be the best way forward, or to at least combine a len(field) check against both 8 and 9.

I appreciate you debugging it. It is an odd one that I struggled with, but I will test more against some of my older data sets to ensure it doesn't break.

astrelsky commented 2 years ago

Thank you @astrelsky. That does change a significant check and could break backward compatibility. I will review and test here. That could be the best way forward, or to at least combine a len(field) check against both 8 and 9.

I appreciate you debugging it. It is an odd one that I struggled with, but I will test more against some of my older data sets to ensure it doesn't break.

No problem. I'm also using a newer procmon version which could be relevant.

Wouldn't it be more effective to check that all the expected fields are there instead of the length? Sure it's more work then a length check but it's only done once and would be more robust. You could log any missing or unexpected fields and skip them accordingly instead of silently producing empty results.

astrelsky commented 2 years ago

@Rurik I think it may be better to remove this check entirely. If you use csv.DictReader on the csv file opened with encoding utf-8-sig you should be able to replace the row indexing with the row name. It should be more stable this way. If a required row isn't present for some reason you would get a KeyError. It should work even if the rows get moved around in a new version of procmon for example.

Rurik commented 2 years ago

These comments are significant and appreciated, @astrelsky. I agree that DictReader would be the optimal path. Instead of blindly validating and guessing the appropriate fields, they can be referenced by key. I am in a position to do work on Noriben now and will start implementing this change now. That would indeed also remove that blind validation for the number of fields, which could break on different versions of procmon.

Rurik commented 2 years ago

v1.8.7 has been merged. This primarily changes the CSV type. I did regression testing against a smaller set of data than normal (on a laptop in hotel), but everything looks correct.

astrelsky commented 2 years ago

v1.8.7 has been merged. This primarily changes the CSV type. I did regression testing against a smaller set of data than normal (on a laptop in hotel), but everything looks correct.

Cool I'll give it a shot tomorrow morning.

I did notice that the default filter causes all process creations to be filtered out on a newer version of procmon. I'll confirm which filter it was and open a separate issue about it tomorrow. (I think it was * or something weird)

And I totally forgot.