Rushaway / sourcebans-web-theme-fluent

(Theme) Fluent theme for Sourcebans.
GNU General Public License v3.0
30 stars 9 forks source link

[BUG] Protests and Submissions #11

Closed tslashd closed 1 year ago

tslashd commented 1 year ago

I updated to latest SourceBans++ dev version and downloaded this fork of aXenDev's theme as old one stopped working. Since then I have found this issue which was not present with the previous version of the theme. Ban protests and submissions are not displayed in the panel, pictures below: Totals: image Protests (same is shown in Archive tab): image Submissions: image

Also noticed some icons not showing up properly: image

P.S: It may not be a bug from theme side I suppose (only assuming that cause they worked correctly with old theme) but would greatly appreciate any tips on fixing these.

Rushaway commented 1 year ago

It look like to be related to Font Awesome. Do you still have this issue?

tslashd commented 1 year ago

Thank you for the response. I just tried the latest master branch (php 8.1), the icons are back and I can see current Protests but not archived ones. Also Bans and Comms are not showing anything now, Submissions still does not show anything.

Rushaway commented 1 year ago

Make sure you have the last commit pushed today on sbpp. https://github.com/sbpp/sourcebans-pp ea487ef will only work with https://github.com/sbpp/sourcebans-pp/pull/883

tslashd commented 1 year ago

That commit exists as I downloaded the latest version of the theme from this repository and it seems that you have merged it here as well. The only one that is missing I believe is https://github.com/sbpp/sourcebans-pp/commit/fcdeb62295b2bebe113e62d5706d23c235580862

Rushaway commented 1 year ago

That commit exists as I downloaded the latest version of the theme from this repository and it seems that you have merged it here as well.

Watch out on the original sbpp commit it have a function added in the include and in init.php you need them.

tslashd commented 1 year ago

Ahhh, my bad, apologies! Seems that everything works now, thank you very much! Appreciate the help! :)

P.S: I just drag and dropped the newest SBPP release just to make sure it's all up to date.