Identify spell

[Rushwind13]

Given I have a dagger And the dagger is cursed And the dagger is unidentified When I display equipment Then the dagger is not labeled as cursed

Given I have a dagger And the dagger is cursed And I have tried to remove it When I display equipment Then the dagger is identified as cursed Then the dagger is labeled as cursed

Given I have a dagger And the dagger is cursed And the dagger is magical And I have tried to remove it When I display equipment Then the dagger is identified as cursed Then the dagger is labeled as cursed Then the dagger is not labeled as magical

Given I have a dagger And the dagger is not cursed And the dagger is magical And the dagger is unidentified When I display equipment Then the dagger is not labeled as cursed Then the dagger is not labeled as magical

Given I have a dagger And the dagger is not cursed And the dagger is magical When I read a Scroll of Identify When I display equipment Then the dagger is not labeled as cursed Then the dagger is labeled as magical

Acceptance Criteria:

• ITEM_FLAG_MAGIC exists
• Items (not ItemDef) carry new flag m_dwKnownIntrinsics (set to 0 in the constructor)
• as intrinsics are discovered about the item (e.g. cursed status), the discovered FLAG is OR-ed into KnownIntrinsics
• any known intrinsics can be displayed on the item in inventory "a Dagger (cursed)", "a Dagger (+0, +0)", "a Dagger (+3, +7) (cursed)"
• any unknown intrinsics (e.g. did not know it was magical) are not displayed "a Dagger"
• Scroll of Identify sets knownintrinsics to all displayable ones (MAGIC|CURSED...)
• Bonus points: different classes have a chance to get "feelings" over time about items for their class -- warriors are good at "feeling" that a weapon (but not a staff or potion or) is cursed, or magical (but not the bonus) "a Dagger (magical)" <-- might mean cursed. Mages/Priests are great at feeling curses, priests don't feel magic items easily, but mages are best at it. "a Dagger" ... time passes... "You feel the Dagger is special" -> "a Dagger (magical)" or "You feel that the Dagger is normal" -> "a Dagger (+0, +0)" -- the longer you hold an item, the more you get to know about it, maybe you pick up cursed first or just "magic" (but it turns out to be a unique, ego weapon, only "fully" discovered by a ?ID)
• bonus points: Items can be cursed, uncursed, or blessed, with bonuses and penalties between versions of the same item.

Note: might need ITEM_FLAG_KNOWN or something, to be able distinguish between "not known if cursed or uncursed" vs "known to be not cursed"

[Rushwind13]

just figured out the "known cursed" thing

• item cursed but I don't know yet item flags: ITEM_FLAG_CURSED known: 0

• I know the item is cursed item flags: ITEM_FLAG_CURSED known: ITEM_FLAG_CURSED

• I know the item is uncursed ("I know the item's cursed status") item flags: 0 known: ITEM_FLAG_CURSED

• I don't know if it's cursed, and it is uncursed (it's not cursed, but I don't know it) item flags: 0 known: 0

So the display happens when known is set, and what is displayed is the underlying item flags/values if( known(cursed) ) display(item.cursed?"cursed":"uncursed") else "" if( known(magic)) display("(+x, +y)") else ""