When SpawnAt() fails, monster is spawned at 0,0 - Githubissues

Rushwind13 / JMoria

My from-scratch implementation of a Roguelike game that will be an homage to IMoria

4 stars 4 forks source link

When SpawnAt() fails, monster is spawned at 0,0 #66

Closed Rushwind13 closed 3 weeks ago

Rushwind13 commented 1 month ago

Given I create a monster When I call SpawnAt(specific point) Then if the spawn fails, the monster is destroyed

AC

the monster gets dumped onto the brains list, the monsters list, and there's a CMonster leaked... fix all this

Notes:

there is a spot in CAIBrain where I found this, so such monsters won't take Brain updates, but it needs to be fixed elsewhere
Dungeon has RemoveMonster... maybe clear any monsters that are STATUS_DEAD every update?
can make monster TakeDamage(monster->curHP) until DEAD
need to clean up Brains list
need to clean up Monsters list
need to not have a monster that is not "Within World"

Rushwind13 commented 3 weeks ago

fixed with https://github.com/Rushwind13/JMoria/pull/80