search

RussKie / gitextensions

GitExtensions is a shell extension, a Visual Studio 2008/2010/2012 plugin and a standalone Git repository tool.
http://sourceforge.net/projects/gitextensions/
Other
1 stars 4 forks source link

Bugs: Replace Translate method with InitializeComplete #7

Open RussKie opened 6 years ago

RussKie commented 6 years ago

Commit: 9316492ecc91bf50adcad63c8db4ac0029340b9c

FormFileHistory line:90 - causes image

drewnoakes commented 6 years ago

I believe I have fixed this on v3-ux. I force pushed a fix to the commit that introduced the bug.

While we're staring at it, do you think that line that sets AutoScaleMode is a good idea? Might it not conflict with the designer's view of the form? Does that app setting even make sense?

RussKie commented 6 years ago

I've found the issue running your branch at a4959c76aab3aa746a5273627383d37d24f76544. FormFileHistory ctor calls another ctor, and both of them have InitializeComplete call. A trivial fix.

While we're staring at it, do you think that line that sets AutoScaleMode is a good idea?

I was thinking maybe forcing all forms to be in Dpi mode. And doing it the same way we test translations - have tests that iterate through all forms and check that they declare AutoScaleMode.Dpi. Any reason why we would want to set AutoScaleMode.None?

drewnoakes commented 6 years ago

I've found the issue running your branch at a4959c7.

Thanks, yes, that's the bug that was fixed and force-pushed.

I created #5145 to track the AutoScaleMode issue.