search

RussTedrake / manipulation

Course notes for MIT manipulation class
BSD 3-Clause "New" or "Revised" License
411 stars 121 forks source link

update closest point docstring in iris notebook #219

Closed anthonysimeonov closed 1 year ago

anthonysimeonov commented 1 year ago

This change is Reviewable

anthonysimeonov commented 1 year ago

updated, please take a look and let me know if this makes more sense.

RussTedrake commented 1 year ago

that makes a lot more sense to me! can we get one of the other TAs to give a sanity check?

buoyancy99 commented 1 year ago

lgtm

liruiw commented 1 year ago

Ellipsoid distance would be x^TCC^Tx iirc and the actual distance to the ellipsoid surface is harder. Also, the returned distance is not used anyways in the code.

buoyancy99 commented 1 year ago

Ellipsoid distance would be x^TCC^Tx iirc.

I think we are talking about ellipsoidal metric not euclidean metric right?

liruiw commented 1 year ago

LGTM