RussTedrake / manipulation

Course notes for MIT manipulation class
BSD 3-Clause "New" or "Revised" License
407 stars 119 forks source link

Use visible_by_default to hide collision geometry #239

Closed jwnimmer-tri closed 1 year ago

jwnimmer-tri commented 1 year ago

The MeshcatVisualizer itself owns the path its publishing to; calling meshcat.SetProperty for visibility no longer works.

See https://github.com/RobotLocomotion/drake/issues/19702.


This change is Reviewable

jwnimmer-tri commented 1 year ago

Note that I created this by hand-editing the JSON. I was hoping there was CI here to double-check me, but I don't see it yet. You might want to test locally before merging, or just after with a fix-forward.

cohnt commented 1 year ago

Oops, I didn't mention in the issue in the Drake repo that I had created a PR for this fix (#238). Looks like our code logic is the same, so either PR should work.