search

Russell-Newton / TikTokPy

Extract data from TikTok without needing any login information or API keys.
https://pypi.org/project/tiktokapipy/
MIT License
213 stars 28 forks source link

Switching between playwright browser (Firefox and Chromium support) #17

Closed terrok9 closed 1 year ago

terrok9 commented 1 year ago

I added a parameter easy to use and some code when the class is called.

terrok9 commented 1 year ago

Run Tox failed with Python 3.8

It works well with a newer version.

Russell-Newton commented 1 year ago

I'll see what failed

Russell-Newton commented 1 year ago

It looks like the lint process fails. Ways to fix this: you can install the test requirements pip install .[test] and run tox -e lint, or we can merge it in and I fix it after the fact (assuming that's the only issue)

terrok9 commented 1 year ago

pip install .[test] Produces: WARNING: Ignoring invalid distribution -ip (c:\python39\lib\site-packages) ERROR: Directory '.[test]' is not installable. Neither 'setup.py' nor 'pyproject.toml' found.

I was not able to test with tox. I think the code is well, it should run smoothly knowing that I verified on my own machine using a new environment. I think is better to merge it, if you need help afterwards, I am happy to help.

Russell-Newton commented 1 year ago

Thanks for the contribution!