search

RussellSpitzer / snakeyaml

Automatically exported from code.google.com/p/snakeyaml
Apache License 2.0
0 stars 1 forks source link

build fails on Java 8 #191

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
use any of available jdk8 (I have tried 8, 8up05, 8up20-ea)

mvn clean package fails with :

Failed tests:
  testGenericBean(org.yaml.snakeyaml.issues.issue61.GenericMapBeanTest)
  testGenericMap(org.yaml.snakeyaml.issues.issue61.GenericMapBeanTest)
  testRootMap(org.yaml.snakeyaml.constructor.ImplicitTagsTest)

Tests run: 829, Failures: 3, Errors: 0, Skipped: 0

Original issue reported on code.google.com by alexande...@gmail.com on 21 May 2014 at 10:56

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 1f10ec14fa5e.

Some changes in javadoc (http://openjdk.java.net/jeps/172) make build to fail 
on javadoc generation (even with -DskipTests).

http://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-
javadoc-tags-are-incomplete

Original comment by alexande...@gmail.com on 21 May 2014 at 11:25

GoogleCodeExporter commented 9 years ago 
Seems like those tests fail because we expect certain order of map's keys in 
tests... Which was kind of fine/same in java before 8.
Looks like java 8 changed the way keys stored in HashMap, so order in 
mapping.entrySet() differs from what test yaml files have.

I think this is bug it TESTs. We should not expect any specific order of keys 
in map (if it's not Linked at least)

Original comment by alexande...@gmail.com on 21 May 2014 at 11:57

GoogleCodeExporter commented 9 years ago 
to make things easy, we can change HashMap in those tests to LinkedHashMap - 
that will guarantee order of keys. 
What do you think? (I have it already and build succeeds, but is it the way?)

Original comment by alexande...@gmail.com on 21 May 2014 at 12:10

GoogleCodeExporter commented 9 years ago 
I agree, we can use LinkedHashMap.

Original comment by py4fun@gmail.com on 21 May 2014 at 3:22

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 0ecfebcf845d.

Original comment by alexande...@gmail.com on 22 May 2014 at 6:26

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision 1955be309d3e.

Original comment by alexande...@gmail.com on 22 May 2014 at 7:00