search

Rust-GCC / gccrs

GCC Front-End for Rust
https://rust-gcc.github.io/
GNU General Public License v2.0
2.31k stars 145 forks source link

Remove unnecessary #include from rust-expr.h #3051

Closed badumbatish closed 4 days ago

badumbatish commented 1 month ago

The file gcc/rust/ast/rust-expr.h has some dummy include line that would be perfect for newcomers to come and participate in open source.

Please remove these two lines in the file as follow, build and compile the code base to make sure every test passes and open a PR.

#include "rust-path.h"
#include "rust-macro.h"
#include "rust-operators.h"
- #include "rust-system.h"
- #include <memory>

Please preview the original issue inn https://github.com/Rust-GCC/gccrs/pull/2982#discussion_r1636723711:

         ah, the system include is still here. you should be able to remove it entirely
liamnaddell commented 1 week ago

Could I be assigned this? I made+tested the change on arm64, and can submit a PR.

badumbatish commented 1 week ago

Hi @liamnaddell ! Yes please open a PR i can help with the review if needed