Closed anderslanglands closed 2 years ago
Haha no pushed too early I think.
On Thu, 4 Nov 2021 at 17:28, RDambrosio016 @.***> wrote:
@.**** commented on this pull request.
In crates/optix/src/acceleration.rs https://github.com/RDambrosio016/Rust-CUDA/pull/1#discussion_r742532333:
for opt in accel_options.iter_mut() {
opt.build_flags |= BuildFlags::ALLOW_UPDATE; opt.operation = BuildOperation::Update; }
let mut hasher = DefaultHasher::new();
build_inputs.hash(&mut hasher);
let hash = hasher.finish();
if hash != self.hash {}
forgot to panic? 🤔
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RDambrosio016/Rust-CUDA/pull/1#pullrequestreview-797343736, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOYQXKHXFGABHRKS6ARS63UKIKXPANCNFSM5HBTD6TA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Oh ok haha
Having to rebase this and fix conflicts every couple of weeks is pretty annoying, so i will probably merge this then finalize the cust changelog and release 0.3. Then OptiX work can be done later
Just enough of optix to get example 02 working - setting up a pipeline and a ShaderBindingTable, launching an optix kernel.