search

Rust-GPU / Rust-CUDA

Ecosystem of libraries and tools for writing and executing fast GPU code fully in Rust.
Apache License 2.0
3.12k stars 120 forks source link

StreamFlags::NON_BLOCKING is unsound because of fringe asynchronous memory copy behavior in CUDA #15

Open RDambrosio016 opened 2 years ago

RDambrosio016 commented 2 years ago

Streams with NON_BLOCKING exhibit very confusing and very dangerous behavior with regards to memcpy due to odd CUDA semantics, per the driver API docs:

For transfers from pageable host memory to device memory, a stream sync is performed before the copy is initiated. The function will return once the pageable buffer has been copied to the staging memory for DMA transfer to device memory, but the DMA to final destination may not have completed.

Because NON_BLOCKING streams do not synchronize with the null (default) stream, this leads to potential race conditions. NVIDIA appears to be aware of this issue, but in the mean time, it may be beneficial to implicitly disable NON_BLOCKING for now. Especially since cust does not expose stream ordered memory allocation.

This is what appears to be happening in the add example sometimes not doing anything on certain systems.

RDambrosio016 commented 2 years ago

I have temporarily disabled StreamFlags::NON_BLOCKING in the unreleased version of cust. This should not have a major performance impact since cust does not expose the null stream anyways. I'll leave this open until NVIDIA gets back to me about this issue

coreylowman commented 2 years ago

@RDambrosio016 could this be solved by using the async version of the copy functions, which require a stream argument? If I'm understanding correctly the issue comes from the default Memcpy functions using the null stream. but since cust doesn't expose the null stream, all the kernels are on different streams than the copies.