search

Rust-GPU / rust-gpu

🐉 Making Rust a first-class language and ecosystem for GPU shaders 🚧
https://rust-gpu.github.io
Apache License 2.0
956 stars 27 forks source link

feat: added image access qualifier, fixes #28 #30

Closed schell closed 1 month ago

schell commented 1 month ago

This adds the ability to specify the image access qualifier from the Image! macro, or from the Image type variables themselves.

Fixes #28 .

schell commented 1 month ago

I just have a few tests to fix up.

LegNeato commented 1 month ago

I'm on my phone so I may have missed it, but I can't find where a test actually uses it?

schell commented 1 month ago

@LegNeato thanks for looking. After running with this in my pipeline, it doesn't fix the problem I was trying to solve. I think I understand now what @eddyb was saying when he said that AccessQualifier is Kernel only, and doesn't apply to shaders.

So, I'm not sure these changes are warranted.