search

Rust-SDL2 / rust-sdl2

SDL2 bindings for Rust
MIT License
2.74k stars 468 forks source link

Fix static linking #1397

Closed sandydoo closed 3 months ago

sandydoo commented 4 months ago

Re-enables static linking when static-link is enabled on its own, without any other packaging features, like use-pkgconfig. This fixes a regression introduced in https://github.com/Rust-SDL2/rust-sdl2/pull/1352.

Cobrand commented 4 months ago

Thanks! Before merging this I need to fix the pipeline, it might take a while before it's merged.

sandydoo commented 4 months ago

A quick way to fix CI is to switch to macos-13, which still uses x86 runners. The new macos-latest is ARM-only.

I'll try to debug the ARM macOS issue.

sandydoo commented 4 months ago

I think the issue is that the video test is not running on the main thread. --test-threads=1 still breaks, but running cargo test --features "..." video works. We might have to run the tests manually then, without the harness. At least on macOS.