Rust-for-Linux / linux

Adding support for the Rust language to the Linux kernel.
https://rust-for-linux.com
Other
3.95k stars 421 forks source link

Improper rendering of table cell in Arch Support page #1069

Closed ojeda closed 1 month ago

ojeda commented 6 months ago

The Arch Support documentation page renders one of the table cells improperly (as an empty bullet list). Please fix it so that the intended rendering (a dash, or similar, meaning "empty/nothing") is used instead.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Reported-by: and a Closes: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.

BWbwchen commented 6 months ago

Hi, I want to work on this issue.

ojeda commented 6 months ago

Of course, please go ahead!

BWbwchen commented 6 months ago

Hi @ojeda,

I have sent the patch. 😃

ojeda commented 6 months ago

Thanks!

https://lore.kernel.org/rust-for-linux/20240323074006.2940679-1-tim.chenbw@gmail.com/

BWbwchen commented 6 months ago

Hi @ojeda,

I have sent another patch https://lore.kernel.org/rust-for-linux/20240324010915.3089934-1-tim.chenbw@gmail.com/

Could you help me to review it? Thank you for your help.

ojeda commented 6 months ago

The patch looked good overall to me (I didn't try rendering yet, but I assume you tried and it works). We will start taking patches for the cycle soon, no worries. Thanks!

BWbwchen commented 6 months ago

Yes, I have rendered it and it worked well. Screenshot_20240328_222600

ojeda commented 1 month ago

Fixed in commit 01848eee20c6 ("docs: rust: fix improper rendering in Arch Support page").