tgross35
commented
1 year ago I am working on enabling some of these. I will exclude unnecessary_safety_comment for now because it has a false positive in macros https://github.com/rust-lang/rust-clippy/issues/10084
Features that we would like to see
Required (we almost certainly want them)
[ ] Macros wrapping expressions in
unsafeblocks when usingunsafe_op_in_unsafe_fn.clippy::macro_metavars_in_unsafe.[ ] Lint to catch
#[no_mangle]on non-repr(C)pub statics.[ ] Support custom
dbg!s in thedbg_macrolint.Nice to have (not critical, we could workaround if needed, etc.)
[ ] Lints that generalize
exit,todo,mem_forget, etc.[ ]
disallowed_namessupport for identifiers.[ ] Per-path lint levels for
DisallowedPath-related lints.[ ] Diagnostic for unexpected paths in configuration file.
disallowed_macros's paths.[ ] Have a lint against usize-to-u64 casts (or, against all integer casts).
[ ] Make
unnecessary_castcover somecore::ffi::c_*cases.[ ]
unnecessary_castdoes not trigger with a local but it does with a parameter.[ ] Ignoring lints added after a given Rust version.
-Dfor some lint groups or leaving Clippy's default for some lints inclippy::all.[ ] Unsafe attributes support.
[ ] Avoid inherent methods on generic smart pointers.
[ ] Split
needless_lifetimes.[ ] Support for
--fixwithout Cargo (e.g. insideclippy-driver).cargo(the binary) would be fine if needed, but not if it requires a Cargo-based structure.[ ]
unsafe externsupport.[ ] Overindented lines lint (similar to
doc_lazy_continuation).[ ] Unneeded
rustas language inrustdoc's documentation examples.Low priority (we will likely not use them in the end)
[ ] Conditional compilation for
clippy.toml?.clippy.tomlon the fly (and usingCLIPPY_CONF_DIRto find it in theobjtreeinstead of thesrctree).[ ] Fine-grained
check-private-items(https://doc.rust-lang.org/clippy/lint_configuration.html#check-private-items).check-private-itemsenabled, but we do not have all the lints covered enabled, and in the future we might want to enable them, thuscheck-private-itemsmay make it harder to start.Done (stabilized, fixed, not needed anymore, etc.)
[x] Support/document running Clippy as a
rustcwrapper.[x] Configuring lint levels when using
clippy-driver.[x] Normalize semicolon inside/outside blocks for
()returning expressions (semicolon_outside_blockandsemicolon_inside_block, 1.68.0).[x] Lint to warn about missing
// SAFETY:explanations (undocumented_unsafe_blocks, 1.58.0).[x] Lint to warn about unexpected
# Safetycontracts (i.e. the reverse of themissing_safety_doclint) (unnecessary_safety_doc, 1.67.0).[x] Lint to warn about unexpected
// SAFETY:comments (i.e. the reverse of theundocumented_unsafe_blockslint) (unnecessary_safety_comment, 1.67.0).// SAFETY:comments also for explaining why safe code makes other unsafe code sound, though.[x] Lint to catch
#[no_mangle]but non-extern "C"(no_mangle_with_rust_abi, 1.69.0).Bugs that we would like to see fixed
Required (we almost certainly want them)
[ ]
undocumented_unsafe_blocksfalse positives around attributes.[ ]
disallowed_macrosfalse negatives.dbg_macroemulation purposes.$t + $tcase): https://github.com/rust-lang/rust-clippy/pull/11439 (1.74).Nice to have (probably not critical, we could workaround if needed, etc.)
Low priority (we will likely not use them in the end)
Done (stabilized, fixed, or not needed anymore, etc.)
[x]
README: document that Clippy may change codegen.[x]
new_ret_no_selffalse positive when returningimpl Trait<Self>.pin-initusage.[x]
macro_metavars_in_unsafefalse negative without statement.