Open ojeda opened 3 years ago
Should we try to turn 487d7578bd036ba57b0998d7af69e0bdcc595da8 into a PR for rust next?
That looks good -- it might make sense to split it into multiple pieces though.
On Sat, Jul 3, 2021 at 1:00 PM John Ericson @.***> wrote:
Should we try to turn 487d757 https://github.com/Rust-for-Linux/linux/commit/487d7578bd036ba57b0998d7af69e0bdcc595da8 into a PR for rust next?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Rust-for-Linux/linux/issues/408#issuecomment-873437546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBB5E6EUDUQ7FVTJ3QTTV462HANCNFSM47S4VRCQ .
-- All that is necessary for evil to succeed is for good people to do nothing.
Yeah, I think many of the new methods can likely be taken without much fuss to upstream -- I started with the easy bits first.
I am not 100% sure about whether upstream would want to use TryReserveError
in all the places I used it, though.
Arc::try_pin is now merged
Arc::try_pin is now merged
Alex, we are actually deprecating Arc
in favor of Ref
(see #377). The only place still using it is binder; I have a long series that removes it but it still needs some cleanup before being ready for review (which is taking longer because I'm working on a hw driver now).
Good point. Well, it'll be there for the next person.
בתאריך יום ה׳, 15 ביולי 2021, 14:25, מאת Wedson Almeida Filho < @.***>:
Arc::try_pin is now merged
Alex, we are actually deprecating Arc in favor of Ref (see #377 https://github.com/Rust-for-Linux/linux/pull/377). The only place still using it is binder; I have a long series that removes it but it still needs some cleanup before being ready for review (which is taking longer because I'm working on a hw driver now).
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Rust-for-Linux/linux/issues/408#issuecomment-880918181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBHRVTHJ3XD4YFT6UFLTX4RYZANCNFSM47S4VRCQ .
Features that we would like to see
Required (we almost certainly want them)
Nice to have (not critical, we could workaround if needed, etc.)
Low priority (we will likely not use them in the end)
Done (stabilized, fixed, not needed anymore, etc.)
[x] Disabling infallible allocations.
[x]
Arc::try_pin
.[x]
try_*
methods foralloc
, usable underno_global_oom_handling
.Box
andVec
via extensions traits and adestructure
/rebuild
pair of functions, so that we avoid having a customalloc
fork like in the past (https://github.com/Rust-for-Linux/linux/pull/402).[x] Disabling
rc
andsync
.[x] Ensure
no_global_oom_handling
builds are warning-free.-Dwarnings
).Bugs that we would like to see fixed
Required (we almost certainly want them)
Nice to have (probably not critical, we could workaround if needed, etc.)
Low priority (we will likely not use them in the end)
Done (stabilized, fixed, or not needed anymore, etc.)