search

RustAudio / audrey

A crate to simplify reading, writing and converting between a variety of audio formats.
Other
132 stars 16 forks source link

Fix sample dependency #28

Closed grantgustafson closed 3 years ago

grantgustafson commented 3 years ago

27

Cocalus commented 3 years ago

This works with my code that stopped building, and passes the tests that I had. I had to change some of my code since it was using the sample/frame/signal reexported by Audrey's use of the sample crate, so this is a breaking change to the API and ideally Audrey would get a new release and break semver with this. I was already using the commit with my PR to fix 24bit, so I just switched to this PR's commit to fix my builds.

I needed to add dasp_signal to my Cargo.toml to restore the signal stuff I was using, but since Audrey doesn't use it it's probably not worth reexporting like sample and frame, especially since it looks like other things were split off as well. The code changes to switch to dasp all look straight forward to me.

mitchmindtree commented 3 years ago

Thank you both, these changes look good to me!