BasePacketReader is badly-behaved if read_packet is not continually drained

RustAudio / ogg

Ogg container decoder and encoder written in pure Rust

Other

113 stars 21 forks source link

BasePacketReader is badly-behaved if read_packet is not continually drained #28

Open Ralith opened 2 years ago

Ralith commented 2 years ago

Pushing every page of a complete ogg file before attempting to read any packets will result in lost packets.

est31 commented 2 years ago

Yeah there is only limited buffering. Maybe this should be pointed out.

Ralith commented 2 years ago

It is very convenient when coupling push-based and pull-based interfaces to push all your data before trying to drain packets, so having undocumented breakage there is definitely an unpleasant surprise.