RustAudio / ogg

Ogg container decoder and encoder written in pure Rust
Other
113 stars 21 forks source link

Make page CRC verification toggleable by end-users #44

Closed AlexTMjugador closed 1 week ago

AlexTMjugador commented 1 week ago

These changes make the Ogg page CRC verification check toggleable at runtime by end-users via a new PageParsingOptions struct that may be passed at reader/parser construction time. I have paid special attention to making the new feature both backwards and forwards compatible, which led me to taking the following design choices:

The fuzzing cfg flag is still honored after these changes by using it to set a default value for the new verify_checksum page parsing option accordingly.

The need for these changes has been brought forward in https://github.com/OptiVorbis/OptiVorbis/issues/101.

AlexTMjugador commented 1 week ago

This PR also bumps the MSRV to 1.61 to fix CI checks, as it is required for the current code to work anyway (the screenshot below is from cargo msrv):

image

AlexTMjugador commented 1 week ago

Thanks for the quick review and merge! :rocket:

I was wondering if there are any plans to publish a release with these changes soon? I'd love to try them out on a new OptiVorbis release too, but no worries if we have to wait a little longer 😉