RustAudio / rnnoise-c

Rust bindings to Xiph's rnnoise denoising library
Other
7 stars 3 forks source link

Move colon to name and use rnnoise-sys by path and version #6

Closed Flakebi closed 4 years ago

Flakebi commented 4 years ago

You can specify a dependency using both, a version and a path. It will pick up the local path when using the git version and the crates.io package will use the version number to get the dependency.

I think the rust style usually is to put the colon to the variable name instead of the type.

est31 commented 4 years ago

I think the rust style usually is to put the colon to the variable name instead of the type.

Yeah that's the Rust style. This project was written in my own style which uses hard tabs, colons next to the type instead of the variable name and sometimes different indentation strategies.

Flakebi commented 4 years ago

Ok, I like tabs too :) What do you think about the Cargo.toml change? rnnoise-sys = { path = "sys", version = "0.1.1" }