search

RustAudio / rnnoise-c

Rust bindings to Xiph's rnnoise denoising library
Other
7 stars 3 forks source link

Mark DenoiseState as Send #8

Closed Flakebi closed 4 years ago

Flakebi commented 4 years ago

Currently, a DenoiseState cannot be sent between threads. I’m not perfectly sure what the preconditions are to mark something as Send. Looking at the C source code, it seems like the state struct only contains buffers and there is no global state or anything other that would prevent it from being used in other threads, so I think marking DenoiseState as Send is fine.

est31 commented 4 years ago

Yeah there shouldn't be any global state. PRs welcome!