RustAudio / rodio

Rust audio playback library
Apache License 2.0
1.66k stars 214 forks source link

Seek support for flac #586

Closed JamieH01 closed 3 weeks ago

JamieH01 commented 3 weeks ago

It appears that flac lacks seeking support. Would this be possible/planned in the future? This is currently whats stopping me from using this.

dvdsk commented 3 weeks ago

by default rodio claxon for flac decoding. If you switch to the symphonia backend you'll get seeking :)

rodio = { version = "some version", features = ["symphonia-flac"] }

dvdsk commented 3 weeks ago

in the future I hope to make the symphonia backends the default since they support the most features. That might be a breaking change so that will be shipped at the same time as when we overhaul the features.

JamieH01 commented 3 weeks ago

oh! thank you!

JamieH01 commented 3 weeks ago

i apologize for the spam issue, i was under the impression that the flac feature that was enabled by default was the only one. maybe just me missing something, but maybe that could be made more clear in the docs?

dvdsk commented 3 weeks ago

i apologize for the spam issue, i was under the impression that the flac feature that was enabled by default was the only one. maybe just me missing something, but maybe that could be made more clear in the docs?

no worries, it is a bit unclear right now. I hope to enable the easier decoder (symphonia) by default in the future but that is a breaking change so it takes a bit of coordination to make sure we dont break ppls code tooo much :)

meanwhile you should feel free to clarify the docs, documentation PR's are always welcome :)