search

RustAudio / rust-lv2

A safe, fast, and modular framework to create LV2 plugins, written in Rust
Apache License 2.0
171 stars 23 forks source link

Change the type of the URI constant to CStr or URI #47

Open JOOpdenhoevel opened 4 years ago

JOOpdenhoevel commented 4 years ago

This is a request from Reddit (link to comment) to change the type of the URI constant of the UriBound trait to CStr or Uri. Then, the constant would be created with the from_bytes_with_nul_unchecked function, which explicitly says that the input has to contain a null character and why this trait is unsafe to implement.

This is mostly a cosmetic change, but a good and helpful one.

YruamaLairba commented 4 years ago

i just updated to rust 1.41.1 to try and "from_bytes_with_nul_unchecked" is not yet stable as const fn.

JOOpdenhoevel commented 4 years ago

Right, I will remove it from this milestone...