Don't require Plugin to impl Default

RustAudio / vst-rs

VST 2.4 API implementation in rust. Create plugins or hosts. Previously rust-vst on the RustDSP group.

MIT License

1.04k stars 91 forks source link

Closed Boscop closed 3 years ago

Boscop commented 3 years ago

fixes https://github.com/RustAudio/vst-rs/issues/153 by implementing Plugin::new for PluginInstance by using unreachable!(). It's safe because it's never called anyway. (Plugin::new is only called on the client side and PluginInstance is only used on the host side): https://github.com/Boscop/rust-vst/blob/0da6e719a26ba67d8302caf26eda1539ee221e81/src/host.rs#L570

Boscop commented 3 years ago

@askeksa Thanks for the review. I applied the suggested changes in the new commit that I just pushed.

Boscop commented 3 years ago

@askeksa Everything ok now? Can I merge?

askeksa commented 3 years ago

Yes, looks good.