search

RustCrypto / KDFs

Collection of Key Derivation Functions written in pure Rust
67 stars 28 forks source link

hkdf: upgrade to pre-release upstream crates #31

Closed tarcieri closed 4 years ago

tarcieri commented 4 years ago

Updates the digest and hmac crates to the new (2018 edition) upstream crates (v0.9.0-pre and v0.8.0-pre respectively).

tarcieri commented 4 years ago

I'll be cutting a final release of these (and the updated dev dependencies) soon if you'd like to hold off until then.

vladikoff commented 4 years ago

The ci needs to be tweaked image

tarcieri commented 4 years ago

Tests are failing because MSRV is 1.41 for these crates. I'll go ahead and bump it in the Travis config.

tarcieri commented 4 years ago

It's green now.

I'd also be happy to do a 2018 edition upgrade for this crate too (I just did it for all of the other RustCrypto crates)

vladikoff commented 4 years ago

I'd also be happy to do a 2018 edition upgrade for this crate too

that would be useful! 👍

tarcieri commented 4 years ago

Opened #32 with a 2018 edition update.

Will go ahead and merge this then rebase #32.

tarcieri commented 4 years ago

Are we committing to not release a new HKDF until after we can update the dependencies again to point at non-prerelease digest and hmac, etc?

Yes, although I plan on cutting final releases of the other crates later this week, if that's ok.

Mostly I'm just trying to get all of the crates updated to the new RustCrypto/traits and so forth to suss out any potential showstoppers before cutting a final release.