ml_kem: Enable zeroization

RustCrypto / KEMs

Collection of Key Encapsulation Mechanisms written in pure Rust

30 stars 15 forks source link

ml_kem: Enable zeroization #51

Closed bifurcation closed 3 months ago

bifurcation commented 3 months ago

I'm not totally sure I understand the zeroize crate and its sharp edges, but I think this implements zeroization correctly. Basically just starts at kem::DecapsulationKey and works down the stack from there.

bifurcation commented 3 months ago

Thanks for the explanation @tarcieri. I accepted your proposed change, and removed the ZeroizeOnDrop impls for the internal types. So that leaves us in the following state:

Internal types (in pke.rs and algebra.rs) implement Zeroize
The public DecapsulationKey type implements Drop (with Zeroize calls) and ZeroizeOnDrop

tarcieri commented 3 months ago

I can cut a v0.2.1 with this feature