search

RustCrypto / KEMs

Collection of Key Encapsulation Mechanisms written in pure Rust
24 stars 12 forks source link

Fixed ML-KEM benches #55

Closed rozbb closed 3 weeks ago

rozbb commented 1 month ago

Benches weren't compiling. They were using non-public deterministic functions. Now they use the random functions. Also I removed key parsing from the encap and decap functions. IMO they should just be doing encap/decap, but I can add ser/deser back in if you think it really belongs there.

tarcieri commented 1 month ago

Aah, I see what was happening: they're tested in CI here:

https://github.com/RustCrypto/KEMs/blob/master/.github/workflows/ml-kem.yml#L67

But that's running cargo build --benches --all-features.

I think this change is fine, but we should also update the CI config to ensure cargo build --benches works without the --all-features in that case.

rozbb commented 1 month ago

Ah makes sense. Ok I’ll do that

rozbb commented 1 month ago

Done