RustCrypto / PAKEs

Password-Authenticated Key Agreement protocols
106 stars 35 forks source link

SRP: tools::powm should use faster constant time exponentiation #18

Closed jpgoldberg closed 2 years ago

jpgoldberg commented 5 years ago

There are methods for much more efficient and cryptographically appropriate modular exponentiation than what is currently implemented.

I'm not familiar enough with the Rust ecosystem to specifically recommend something at this point. (Indeed, I read this code in the hopes of finding the recommended practice.)

newpavlov commented 5 years ago

Can you link any references, which we can use? srp crate is explicitly not constant-time (see README, I probably also should add disclaimer to the crate docs), but I will be happy to accept any PRs which will improve crates in this regard!

jbis9051 commented 2 years ago

This was fixed by https://github.com/RustCrypto/PAKEs/pull/78 and should be closed

tarcieri commented 2 years ago

Fixed in #78