search

RustCrypto / PAKEs

Password-Authenticated Key Agreement protocols
106 stars 35 forks source link

spake2 code reorganization #6

Closed newpavlov closed 6 years ago

newpavlov commented 6 years ago

I've moved some tests to tests folder and others to tests.rs. Also code from spake2.rs is moved to lib.rs.

newpavlov commented 6 years ago

BTW I think it could be worth to allow failure of the rustfmt pass.

warner commented 6 years ago

hrm.. I've had folks encourage me to be strict about rustfmt, to keep things tidy, but I have to admit that it's annoying when 80% of submitted PRs fail because of something that's easy enough for us to fix afterwards.

Yeah, let's make that optional, but we'll need to make it a point to re-check rustfmt frequently, and also to make sure the tree is rustfmt-clean before we start making functional changes, so that commits don't have unrelated changes included in them.

warner commented 6 years ago

Oh, I noticed the #![cfg_attr(test, deny(warnings))] that was in lib.rs went away.. should we include that in the new tests.rs ?

warner commented 6 years ago

great, looks good to me

newpavlov commented 6 years ago

I've added #![deny(warnings)] to the crate. (I probably should do it for other crates as well)

newpavlov commented 6 years ago

BTW if you'll have time it would be nice if you'll add crate level docs with a basic description of SPAKE2 and usage example(s).