search

RustCrypto / asm-hashes

Assembly implementations of cryptographic hash functions
46 stars 26 forks source link

Migrating to inline assembly (Rust 1.59) #45

Closed tarcieri closed 5 months ago

tarcieri commented 2 years ago

With the forthcoming release of Rust 1.59 at the end of February, which stabilizes inline assembly, I think it's time to start planning on eventually retiring this repo and migrating to inline assembly instead.

This should simplify a number of things like linking, testing, and overall crate/repo structure.

roblabla commented 2 years ago

Would you accept a PR adding a feature enabling inline asm? The use-case is that I'm cross-compiling stuff, and having a working assembler for some of the platforms I target is painful. Using rustc's built-in support for assembly would mean less moving parts for me.

newpavlov commented 2 years ago

Yes, but the PR would have to be opened against the hashes repository, not this one. To prevent breakage, inline assembly impl should be behind its own feature (e.g. inline-asm) until the next breaking release.

newpavlov commented 5 months ago

Going to close this issue since we decided to deprecate these crates and implement ASM backands directly in the hash crates.