search

RustCrypto / asm-hashes

Assembly implementations of cryptographic hash functions
46 stars 26 forks source link

Update actions/checkout in GitHub Actions workflows to v3 #46

Closed striezel closed 2 years ago

striezel commented 2 years ago

Updates the actions/checkout action used in the GitHub Actions workflow to its newest version.

Changes in actions/checkout:

v3.1.0

  • Use @actions/core saveState and getState
  • Add github-server-url input

v3.0.2

  • Add input set-safe-directory

v3.0.1

  • Fixed an issue where checkout failed to run in container jobs due to the new git setting safe.directory
  • Bumped various npm package versions

v3.0.0

  • Update to node 16

As far as I can tell this should all be backwards compatible, so I do not expect any breakage.

striezel commented 2 years ago

The clippy failure (https://github.com/RustCrypto/asm-hashes/actions/runs/3211982377/jobs/5250522640) seems to be due to problems with the crates.io index:

Updating crates.io index
error: failed to get `cc` as a dependency of package `md5-asm v0.5.0 (/home/runner/work/asm-hashes/asm-hashes/md5)`

Caused by:
  failed to fetch `[https://github.com/rust-lang/crates.io-index`](https://github.com/rust-lang/crates.io-index%60)

Caused by:
  error reading from the zlib stream; class=Zlib (5)
Error: Process completed with exit code 101.
newpavlov commented 2 years ago

Looks like the CI failure is caused by: https://github.com/rust-lang/cargo/issues/10303 We probably need to apply the workaround used in the linked PRs.