Closed NobodyXu closed 1 year ago
Looks good! Could you fix the MacOS CI failure by bumping its MSRV? Also, it would be nice to check if Windows builds are indeed fixed, otherwise we can remove the MAIN_SEPARATOR
workaround.
Looks good! Could you fix the MacOS CI failure by bumping its MSRV?
I've bumped the MacOS MSRV to 1.54.0 to fix the error.
It's unfortunate that bumping it to other 1.4x.0 versions doesn't work.
Also, it would be nice to check if Windows builds are indeed fixed, otherwise we can remove the
MAIN_SEPARATOR
workaround.
I've tested it in CI and it doesn't fix the error, so I've reverted it.
and fixed the path to assemblies on windows.
I encountered link time failure when compiling on Windows locally and on CI:
I think this might have something to do with use of deprecated feature of
cc::Build::compile
:It should pass just a name instead and msvc would deal with that:
Also, thebuild.rs
are using/
on windows, this might also be the cause of failure.Related issue https://github.com/Byron/gitoxide/issues/917#
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com