sm4: simd support for armv8, x86_64

RustCrypto / block-ciphers

Collection of block cipher algorithms written in pure Rust

677 stars 130 forks source link

sm4: simd support for armv8, x86_64 #390

Open zonyitoo opened 1 year ago

zonyitoo commented 1 year ago

x86_64: aesni, avx2
armv8: crypto-extension, neon

newpavlov commented 1 year ago

Thank you! It's a relatively sizable PR, so it will take some time for us to properly review it.

zonyitoo commented 10 months ago

Hello @newpavlov , what do you think about this PR?

tarcieri commented 10 months ago

@zonyitoo it looks pretty impressive but as @newpavlov said it is large and because of that hard to review, especially because it contains so many backends in a single PR.

We're about to start making some breaking changes and I was looking through to see if we should land this PR first. I think it would probably make sense to try to land this as part of our next breaking release cycle. See #394