search

RustCrypto / block-ciphers

Collection of block cipher algorithms written in pure Rust
659 stars 130 forks source link

aes: compilation errors on `cg_clif` due to lack of intrinsics support #391

Closed tarcieri closed 9 months ago

tarcieri commented 10 months ago

See:

Cranelift doesn't support these intrinsics yet, so compilation fails it inserts traps instead of using the intrinsics.

I've suggested cfg(aes_force_soft) as a workaround, but it would be nice if this just worked, and even better if hardware acceleration worked.

One option would be to use inline assembly, which would also provide an avenue to address #385.

tarcieri commented 10 months ago

cc @bjorn3

newpavlov commented 10 months ago

It's clearly a Cranelift issue and I don't think we should do anything to address it.

AppleSheeple commented 10 months ago

Cranelift doesn't support these intrinsics yet, so compilation fails.

For the sake of accuracy, missing intrinsics trigger warnings about traps used instead of unimplemented intrinsics. Compilation does not fail!

tarcieri commented 9 months ago

Looks like this will be addressed by https://github.com/rust-lang/rustc_codegen_cranelift/pull/1425

Going to go ahead and close this.