tls_codec: no support for `uint24_t`-prefixed variable length vectors

RustCrypto / formats

Cryptography-related format encoders/decoders: DER, PEM, PKCS, PKIX

235 stars 125 forks source link

tls_codec: no support for `uint24_t`-prefixed variable length vectors #1277

Closed tnytown closed 8 months ago

tnytown commented 9 months ago

tls_codec is missing the TlsByteSliceU24 and TlsByteVecU24 types. These are useful in verifying Signed Certificate Timestamps, which contain some uint24 sized fields in thedigitally-signed component.

I've worked around this in sigstore-rs by hacking together a partial implementation of TlsByteVecU24, but it'd be nice to have a proper one upstream. I'm more than happy to contribute this myself if it'd be helpful.

franziskuskiefer commented 9 months ago

Apparently no one needed u24 yet. @tnytown do you want to upstream your changes here? I'd be happy to review them and get it merged.

tnytown commented 7 months ago

@franziskuskiefer Can we get a new tls_codec release with this feature? I'd like to switch over to the upstream implementation in https://github.com/sigstore/sigstore-rs/pull/326 :)

franziskuskiefer commented 7 months ago

Yes! I was waiting for #1330. I have to see if that get's in or if I just do one now. Let's say we get a release out this week.