spki: borrow the public key in `spki::from_key`

RustCrypto / formats

Cryptography-related format encoders/decoders: DER, PEM, PKCS, PKIX

235 stars 125 forks source link

Closed baloo closed 8 months ago

baloo commented 8 months ago

SubjectPublicKeyInfoOwned does not require the ownership of the key.

This is a breaking change.

baloo commented 8 months ago

Guess I'll need to break this in two. Release a minor of spki with the first change, then bring that in x509-cert in a follow up.

baloo commented 8 months ago

I am surprised to see minimal version of x509 work here. I expected it to fail, is this not a breaking change?!

tarcieri commented 8 months ago

Not sure how it would be possible?