RustCrypto / formats

Cryptography-related format encoders/decoders: DER, PEM, PKCS, PKIX
228 stars 122 forks source link

Forward feature flags to the spki crate #1358

Closed kornelski closed 4 months ago

kornelski commented 4 months ago

Allows creation of spki fingerprints without having to add the spki crate separately and keep versions in sync.

tarcieri commented 4 months ago

Looks like the additional features are causing a combinatorial explosion in cargo-hack which made CI fail with this:

error: linking with `cc` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/home/runner/.rustup/toolchains/1.75.0-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/opt/hostedtoolcache:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin" VSLANG="1033" "cc" "-m64" "/tmp/rustc4EHxby/symbols.o" "/home/runner/work/formats/formats/target/debug/deps/general_name-a55a072bbaecfbc7.general_name.81991d992fadc583-cgu.00.rcgu.o" "/home/runner/work/formats/formats/target/debug/deps/general_name-a55a072bbaecfbc7.general_name.81991d992fadc583-cgu.01.rcgu.o" "/home/runner/work/formats/formats/target/debug/deps/general_name-a55a072bbaecfbc7.general_name.81991d992fadc583-cgu.02.rcgu.o" "/home/runner/work/formats/formats/target/debug/deps/general_name-a55a072bbaecfbc7.general_name.81991d992fadc583-cgu.03.rcgu
  = note: /usr/bin/ld: final link failed: No space left on device

Perhaps for now you could exempt these features from cargo-hack in the CI config?