RustCrypto / formats

Cryptography-related format encoders/decoders: DER, PEM, PKCS, PKIX
243 stars 129 forks source link

base32ct: fix broken encoding of unpadded base32 #1421

Closed dodomorandi closed 4 months ago

dodomorandi commented 4 months ago

Keep in mind that this changes the output of the encoded forms and the encoded length from the utility function. Even if not technically a breaking change, users should be aware that the previous versions could lead to broken base32 strings.

Maybe it should be better to yank previous versions after a patch version is out. Eventually it could be also worth releasing a 0.1.1 with the fix. Choose what you consider the best option for the project.

Fixes #1420

EDIT: I used the "breaking change" notation for commit f6aafb6, let me know if you do not consider so, I will reword the commit.