RustCrypto / hashes

Collection of cryptographic hash functions written in pure Rust
1.82k stars 247 forks source link

[Q&A] Is the SHA1 implementation 'hardened'? #431

Closed Byron closed 1 year ago

Byron commented 1 year ago

I am using this crate over at gitoxide for pure Rust builds and this question was ask on reddit recently.

Also I am putting 'hardened' in quotes as I don't know if it's the correct term, but it's used in the git documentation accordingly.

Thanks for your help

newpavlov commented 1 year ago

No, currently the sha1 crate does not implement collision detection. See #204.

We are ready to accept a PR which would implement it, but we do not plan to work on it ourselves in the near future.

Byron commented 1 year ago

Thanks a lot for letting me know, much appreciated.

I am happy to give it a try, thinking that @pascalkuthe is probably able to do the significant mentoring that this would take 😅.